-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace activity query with new API endpoint #1894
Conversation
{ terms => { status => [qw< cpan latest >] } }, | ||
); | ||
} | ||
my %args = map { $_ => $c->req->parameters->{$_} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oalders wasn't sure whether to create a new hash with the args or just pass $c->req->parameters
to request
- what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I think that's a good way to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
{ terms => { status => [qw< cpan latest >] } }, | ||
); | ||
} | ||
my %args = map { $_ => $c->req->parameters->{$_} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I think that's a good way to handle it.
API now provides a new endpoint for activity info, we don't need to send a query from WEB anymore.
48b3c8e
to
7fc5e58
Compare
API now provides a new endpoint for activity info, we don't
need to send a query from WEB anymore.